-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict node access to cluster metadata service #203
Restrict node access to cluster metadata service #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation will force a recreation of the cluster and the node pool if the user tries to migrate from a GA module to a beta module because adding workload_metadata_config
forces recreation. Similar to #205, can we implement this in a way where workload_metadata_config
is passed an empty array if node_metadata
is set to "UNSPECIFIED"
, or will that have a different effect?
@aaron-lane you are correct that |
Thanks @marko7460 and @dmyerscough! |
…etadata Restrict node access to cluster metadata service
This PR is implementation of #166 based on @aaron-lane's last comment.
See #166 for more details.