Fix Katello product resource API call #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreman_katello_product used an old wrapper that did not include location_id and organization_id in the payload of calls towards the API. Resolves terraform-coop#54 Signed-off-by: Dominik Pataky <pataky@mindful-security.eu>
On the way to fix the creation, modification and deletion of Katello products, it turned out that Katello uses async responses in its API. Specifically, the destroy (DELETE) endpoints return an async task, which must be checked for completion. This check is now implemented. If a product is destroyed, the API client detects the usage of foreman_tasks and invokes a routine to check the task by its ID, waiting for it to finish. Signed-off-by: Dominik Pataky <pataky@mindful-security.eu>
Signed-off-by: Dominik Pataky <pataky@mindful-security.eu>
As seen in https://apidocs.theforeman.org/katello/latest/apidoc/v2/products.html, the organization_id is a required parameter for the GET endpoint. It is now sent with the name query term. Signed-off-by: Dominik Pataky <pataky@mindful-security.eu>
Signed-off-by: Dominik Pataky <pataky@mindful-security.eu>
|
This one's ready for its purpose to fix the katello product resource calls. It also adds handling for the async "ForemanTask" objects, which are the return type in the Katello API. To not further bloat this PR, I will continue on another branch for #141 |
|
@lhw would you like me to split the PR into two separate PRs, one containing the fix for katello_product and the other for the Katello async ForemanTasks? |
Signed-off-by: Dominik Pataky <pataky@mindful-security.eu>
lhw
approved these changes
Jan 4, 2024
|
Hello, Any news on the progress of this PR ? Regards, |
|
Merged, had no conflicts - feel free to test in your environment @lukry59 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreman_katello_product used an old wrapper that did not include location_id and organization_id in the payload of calls towards the API.
Resolves #54