Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add S3 endpoint dns_entry output #640

Closed
wants to merge 1 commit into from
Closed

feat: Add S3 endpoint dns_entry output #640

wants to merge 1 commit into from

Conversation

tx-kstav
Copy link

Description

Add output for dns_entry of S3 endpoint.

Motivation and Context

I was missing the output for my use case.

Breaking Changes

I have not found anything broken. It is a simple addition in outputs, it should not break anything.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have tested the change against my own VPC. The output is correctly shown as shown below (details omitted), and I can use it in other resources in my Terragrunt code, as a dependency.
vpc_endpoint_s3_dns_entry = [
  {
    "dns_name" = "*.vpce-XXX-YYY.s3.eu-west-1.vpce.amazonaws.com"
    "hosted_zone_id" = "ZZZ"
  },
  {
    "dns_name" = "*.vpce-XXX-YYY-eu-west-1b.s3.eu-west-1.vpce.amazonaws.com"
    "hosted_zone_id" = "ZZZ"
  },
  {
    "dns_name" = "*.vpce-XXX-YYY-eu-west-1a.s3.eu-west-1.vpce.amazonaws.com"
    "hosted_zone_id" = "ZZZ"
  },
  {
    "dns_name" = "*.vpce-XXX-YYY-eu-west-1c.s3.eu-west-1.vpce.amazonaws.com"
    "hosted_zone_id" = "ZZZ"
  },
]

Thank you.

@tx-kstav
Copy link
Author

@bryantbiggs should i close this and wait for #635 ?

@bryantbiggs
Copy link
Member

thanks for the PR @tx-kstav ! I think #635 will be the direction so that endpoint management is more scalable for the module but lets wait and see. I will add this PR to the list of issues/PRs closed by that PR so that if it does go through, things will get cleaned up. its ok to leave open for now

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants