Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SSM endpoint and SSM endpoint test fixtures. #196

Closed

Conversation

tbugfinder
Copy link
Contributor

@antonbabenko
Please think about if such a feature would be supported within the module to fix #195 or if it's preferred to have a new registry module just building Interface VPC endpoints.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition to this module, though I am not sure we need such example. I will try to review it and merge during xmas week. Thanks a lot!


variable "ssm_endpoint_security_group_ids" {
description = "List of security group IDs applied to the SSM interface endpoint."
type = "list"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add default = []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the default setting.

Any idea how to deal with the requirement that subnets have to be unique within AZs? It's not possible just to add all public/private subnets as this could add multiple subnets of the same AZ(s).

@antonbabenko
Copy link
Member

v1.52.0 has been released with both SSM and EC2 VPC endpoints.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: SSM Endpoint
2 participants