-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SSM endpoint and SSM endpoint test fixtures. #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great addition to this module, though I am not sure we need such example. I will try to review it and merge during xmas week. Thanks a lot!
|
||
variable "ssm_endpoint_security_group_ids" { | ||
description = "List of security group IDs applied to the SSM interface endpoint." | ||
type = "list" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add default = []
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the default setting.
Any idea how to deal with the requirement that subnets have to be unique within AZs? It's not possible just to add all public/private subnets as this could add multiple subnets of the same AZ(s).
4de548f
to
412b462
Compare
412b462
to
c9c9215
Compare
v1.52.0 has been released with both SSM and EC2 VPC endpoints. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
@antonbabenko
Please think about if such a feature would be supported within the module to fix #195 or if it's preferred to have a new registry module just building Interface VPC endpoints.