Enable classiclink everywhere

[poolski]

Rather than having the option to enable ClassicLink only for the default VPC, this PR allows users to enable ClassicLink for any VPCs they create.

This is especially useful if you're looking to use Terraform to migrate from an EC2 Classic environment over to VPC but also want to create and manage your own VPCs rather than sticking with the default that AWS provides.

[antonbabenko]

Thanks @poolski !

Looks good in general.

Could you try to run the example code of this module (complete-vpc) in AWS account which was created since 2014 (or so) AND in regions where classiclink has never existed as a concept. I think it will fail because AWS returns different structure of the response (see comments in #121 for related change).

If it works, let's get this merged.

[poolski]

You're right in that it will fail in regions where ClassicLink has never existed in the first place, but when run in regions where ClassicLink does exist with an account created in 2018, the API call passes:

terraform apply  --target=module.platform.module.vpc.aws_vpc.this

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

But nothing actually happens in AWS.

Given that it's false by default, there's little chance of someone triggering it by accident, but it might help folks with legacy EC2 infrastructure.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.