Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default_route_table_tags not wired up? #146

Closed
lorengordon opened this issue Jun 22, 2018 · 6 comments
Closed

default_route_table_tags not wired up? #146

lorengordon opened this issue Jun 22, 2018 · 6 comments

Comments

@lorengordon
Copy link
Contributor

I see default_route_table_tags in variables.tf and in the readme, but when I tried to use it nothing happened. Looks like it's not wired up in main.tf?

> grep -c default_route_table_tags main.tf
0
@antonbabenko
Copy link
Member

Good catch!

v1.37.0 is out.

@lorengordon
Copy link
Contributor Author

5 min! That's gotta be a record! 😂 You're a rockstar @antonbabenko

@lorengordon
Copy link
Contributor Author

Oh you just removed it. lol. How about if I work a pr that adds support later today?

@antonbabenko
Copy link
Member

We have had some challenges with aws_default_route_table resource which turned out to be pretty advanced (it probably requires another lifecycle) and it gives little benefits, so it was added and then it was removed from this module.

Search code base of this module for this resource and there were some discussions in issues about it for some time.

@lorengordon
Copy link
Contributor Author

I remember seeing some of that traffic, but I thought it was before all the default VPC management options were fleshed out, so I thought this was re-added with those extra options. I'd like this option just for the sake of consistency. I'll poke around and try to better understand what the problem was before (I never encountered any problems when using this in the earlier support).

lorengordon added a commit to lorengordon/terraform-aws-vpc that referenced this issue Jun 22, 2018
@lorengordon
Adds support for setting tags on the default route table
421de04 
Uses a data source to retrieve and preserve the routes
that are currently associated with the route table. This
works around prior problems with supporting this resource,
as described in terraform-aws-modules#95.

Fixes terraform-aws-modules#146
@lorengordon lorengordon mentioned this issue Jun 22, 2018
Closed
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
waddamski pushed a commit to hmrc/terraform-aws-vpc that referenced this issue Jul 5, 2024
@antonbabenko
Removed obsolete default_route_table_tags (fixed terraform-aws-module…
995360b 
…s#146)
waddamski pushed a commit to hmrc/terraform-aws-vpc that referenced this issue Jul 5, 2024
@antonbabenko
Removed obsolete default_route_table_tags (fixed terraform-aws-module…
58ac8ef 
…s#146)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-adds support for setting tags on the default route table lorengordon/terraform-aws-vpc
2 participants
@antonbabenko @lorengordon