Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update subnet group to fix name vs. name_prefix #312

Merged

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Mar 12, 2021

Description

  • remove use of var.identifier from sub-module and instead rely on var.name
  • allow for either name or name_prefix in the subnet sub-module; currently defaults name_prefix

Motivation and Context

Closes #42
Closes #48
Closes #121
Closes #209
Closes #223
Closes #250
Closes #280
Closes #290

Breaking Changes

No - other than description change below, there should be no changes for users

For users who are looking to upgrade, they should perform the following change if they wish to avoid any changes:

	...
	# Set the following description
	db_subnet_group_description = "Database subnet group for ${var.identifier}"
	...

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • Tested and validated using the update examples/complete-mysql and `examples/complete-postgresql projects

@bryantbiggs
Copy link
Member Author

@antonbabenko let me know if you have any questions/concerns on this one

@antonbabenko antonbabenko merged commit 1245fac into terraform-aws-modules:master Mar 14, 2021
@antonbabenko
Copy link
Member

Looks good (I just missed this one among hundreds of others github sends me) :)

v2.28.0 has been just released.

@bryantbiggs bryantbiggs deleted the fix/subnet-group branch March 14, 2021 17:25
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants