Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reverts endpoint variable change from e95cde8 #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexTraxinger
Copy link

Description

Reverts a change made in e95cde8 where a variable was changed, breaking SNS topic subscriptions.

Motivation and Context

Fixes #238

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@AlexTraxinger AlexTraxinger changed the title fix: reverts endpoint variable change from e95cde8 Fix: reverts endpoint variable change from e95cde8 Oct 14, 2024
@AlexTraxinger AlexTraxinger changed the title Fix: reverts endpoint variable change from e95cde8 fix: Reverts endpoint variable change from e95cde8 Oct 14, 2024
@rtest12
Copy link

rtest12 commented Nov 8, 2024

@antonbabenko
Could you please merge and release it?

Copy link

github-actions bot commented Dec 9, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 9, 2024
@AlexTraxinger
Copy link
Author

@antonbabenko is anything still needed to have this approved and merged?

@github-actions github-actions bot removed the stale label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS Lambda subscription endpoint is wrong
2 participants