Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update VPC CNI policy to 3/4/24 #476

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

vuskeedoo
Copy link
Contributor

Update VPC CNI policy to version released on 3/4/24. https://docs.aws.amazon.com/aws-managed-policy/latest/reference/AmazonEKS_CNI_Policy.html

Description

The VPC CNI policy is missing ec2:DescribeSubnets from the updated policy.

Motivation and Context

The AWS managed VPC CNI 1.18.0 uses ec2:DescribeSubnets.

Breaking Changes

Updates VPC CNI policy.
Open issue: #474

How Has This Been Tested?

  • I have tested with a local project. This is the Terraform plan. It shows ec2:DescribeSubnets being added.
# module.eks.module.vpc_cni_irsa_role.aws_iam_policy.vpc_cni[0] will be updated in-place
  ~ resource "aws_iam_policy" "vpc_cni" {
        id          = "arn:aws:iam::<redacted>:policy/AmazonEKS_CNI_Policy-20240117193907447200000001"
        name        = "AmazonEKS_CNI_Policy-20240117193907447200000001"
      ~ policy      = jsonencode(
          ~ {
              ~ Statement = [
                  ~ {
                      ~ Action   = [
                            # (3 unchanged elements hidden)
                            "ec2:DescribeTags",
                          + "ec2:DescribeSubnets",
                            "ec2:DescribeNetworkInterfaces",
                            # (6 unchanged elements hidden)
                        ]
                        # (3 unchanged attributes hidden)
                    },
                    {
                        Action   = "ec2:CreateTags"
                        Effect   = "Allow"
                        Resource = "arn:aws:ec2:*:*:network-interface/*"
                        Sid      = "CreateTags"
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
        tags        = {}
        # (6 unchanged attributes hidden)
    }

@vuskeedoo vuskeedoo changed the title Update VPC CNI policy to 3/4/24 feat: Update VPC CNI policy to 3/4/24 Apr 8, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit f9d5e28 into terraform-aws-modules:master Apr 8, 2024
34 of 35 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 8, 2024
## [5.39.0](v5.38.0...v5.39.0) (2024-04-08)

### Features

* Enable override policy name iam-group-with-assumable-roles-policy ([#468](#468)) ([bf013d2](bf013d2))
* Update VPC CNI policy to 3/4/24 ([#476](#476)) ([f9d5e28](f9d5e28))
@antonbabenko
Copy link
Member

This PR is included in version 5.39.0 🎉

Copy link

github-actions bot commented May 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants