feat: Add support for throughput parameter for gp3 volumes #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidprak
force-pushed
the
sidprak/throughput-gp3
branch
from
6d95c78 to
ae6c425
Compare
|
I guess this is the first PR after terraform 0.14 was released, so I had to format with 0.14 which changed a few files. The last commit contains only those formatting changes. |
AWS API wants a value between 125 and 1000.
|
Can you update the default to gp3 instead of gp2 so i can kill my merge? https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1134/files |
barryib
changed the title
barryib
approved these changes
Dec 22, 2020
|
Thanks @sidprak |
Lena-nfb
pushed a commit
to Lena-nfb/terraform-aws-eks
that referenced
this pull request
Dec 23, 2020
zimbatm
added a commit
to zimbatm/terraform-aws-eks
that referenced
this pull request
Jan 14, 2021
…erraform-aws-modules#1146)" This reverts commit 7d6e672.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Fixes #1130
Supporting the throughput setting in block device mapping for gp3 volumes.
Checklist