feat: Allow disabling service creation to support creating just a task definition #176

lancedikson · 2024-03-03T09:18:36Z

Description

The new create_service_resource variable controls whether a service resource should be created (which is true by default) allowing skipping creation of the service when it's not required.

Motivation and Context

Resolves Support for scheduled tasks/standalone task definitions and container definitions #162

Breaking Changes

No breaking changes were introduced in the PR.

How Has This Been Tested?

I have updated at least one of the examples/* to demonstrate and validate my change(s)
I have tested and validated these changes using one or more of the provided examples/* projects

I have executed pre-commit run -a on my pull request

bryantbiggs

can we add an example of how to use this so we can validate it works as intended

lancedikson · 2024-03-03T16:29:27Z

@bryantbiggs, sure, I've added an example in the last commit. In this case I haven't tested the example as I don't have a sandbox account I can play around easily with it at the moment, though tf plan shows exactly what I'd expect — cluster + task definition + all supporting resources, without service and autoscaling groups, LBs, etc. Would that be enough for you to test it out and see it this helps? In the meantime, I will apply the proposed change in the development stage over our own resources tomorrow and see how it works for a real use case.

lancedikson · 2024-03-04T12:58:25Z

Getting back to you with an update: the fix worked for our case — an ECS cluster + a standalone task definition for it. Works as expected. We're going to use the branch until it's implemented as a part of the official module. @bryantbiggs waiting for your feedback regarding the example I provided. I'm happy to complete the rest of the change-related routines if you confirm that the solution is aligned with the whole module concept 🙏

bryantbiggs

Looks great, few tweaks to update - make sure to run pre-commit run -a to update docs and format code to pass CI checks

examples/standalone-task/main.tf

main.tf

modules/service/main.tf

modules/service/variables.tf

lancedikson · 2024-03-10T09:00:57Z

Thanks for the review and sorry for the silence — I've been feeling unwell. Will try to push the necessary changes today 👌

Addressing the issue #162 #162 The new create_service_resource variable controls whether a `service` resource should be created (which is `true` by default), but still allows skipping creation of the service when it's not required.

lancedikson · 2024-03-10T15:08:49Z

@bryantbiggs all checks are now passed, though I haven't tested the Fargate example on a real account. Could you please help out with this? I still don't have a spare sandbox for testing out open-source tools. However, I tested the change in the branch on our dev-account over the resource we configured last week using the proposed change — it still works there.

bryantbiggs · 2024-03-11T21:57:37Z

I'll test this tonight/early tomorrow - there are a few minor tweaks we'll need to make, if you enable us to contribute to your PR we can push them directly here, otherwise I'll cut a PR against your PR (meta!)

lancedikson · 2024-03-11T22:13:43Z

Thanks! Sure, I've added you to our fork — feel free to modify the branch of this PR

…sion

bryantbiggs · 2024-03-12T00:21:45Z

examples/fargate/main.tf

@@ -114,6 +114,7 @@ module "ecs_service" {

      linux_parameters = {
        capabilities = {
+          add = []


just to quiet the diff

bryantbiggs · 2024-03-12T00:22:22Z

modules/container-definition/main.tf

@@ -60,7 +60,7 @@ locals {
    secrets                = length(var.secrets) > 0 ? var.secrets : null
    startTimeout           = var.start_timeout
    stopTimeout            = var.stop_timeout
-    systemControls         = length(var.system_controls) > 0 ? var.system_controls : null
+    systemControls         = length(var.system_controls) > 0 ? var.system_controls : []


this was also to quiet the diff

bryantbiggs · 2024-03-12T00:22:49Z

modules/service/outputs.tf

@@ -59,6 +59,11 @@ output "task_definition_family" {
  value       = try(aws_ecs_task_definition.this[0].family, null)
 }

+output "task_definition_family_revision" {


seems like this could come in handy for others

bryantbiggs

thank you! (feel free to remove my access to your fork at your convenience, thanks again!)

## [5.10.0](v5.9.3...v5.10.0) (2024-03-12) ### Features * Allow disabling service creation to support creating just a task definition ([#176](#176)) ([94c992a](94c992a)), closes [#162](#162)

antonbabenko · 2024-03-12T00:24:05Z

This PR is included in version 5.10.0 🎉

github-actions · 2024-04-13T01:55:36Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

lancedikson changed the title ~~feat: added create_service_resource variable support~~ Added create_service_resource variable support Mar 3, 2024

lancedikson changed the title ~~Added create_service_resource variable support~~ feat: Added create_service_resource variable support Mar 3, 2024

bryantbiggs reviewed Mar 3, 2024

View reviewed changes

bryantbiggs marked this pull request as ready for review March 4, 2024 14:13

bryantbiggs reviewed Mar 4, 2024

View reviewed changes

bryantbiggs changed the title ~~feat: Added create_service_resource variable support~~ feat: Allow disabling service creation to support creating just a task definition Mar 4, 2024

feat: added create_service variable support

abb9841

Addressing the issue #162 #162 The new create_service_resource variable controls whether a `service` resource should be created (which is `true` by default), but still allows skipping creation of the service when it's not required.

chore: Update example, add output for task definition family and revi…

32bba0e

…sion

bryantbiggs reviewed Mar 12, 2024

View reviewed changes

bryantbiggs approved these changes Mar 12, 2024

View reviewed changes

bryantbiggs merged commit 94c992a into terraform-aws-modules:master Mar 12, 2024
11 checks passed

bryantbiggs deleted the feat/standalone-task-definition branch March 12, 2024 00:23

github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Allow disabling service creation to support creating just a task definition #176

feat: Allow disabling service creation to support creating just a task definition #176

lancedikson commented Mar 3, 2024 •

edited

Loading

bryantbiggs left a comment

lancedikson commented Mar 3, 2024 •

edited

Loading

lancedikson commented Mar 4, 2024

bryantbiggs left a comment

lancedikson commented Mar 10, 2024

lancedikson commented Mar 10, 2024

bryantbiggs commented Mar 11, 2024

lancedikson commented Mar 11, 2024

bryantbiggs Mar 12, 2024

bryantbiggs Mar 12, 2024

bryantbiggs Mar 12, 2024

bryantbiggs left a comment

antonbabenko commented Mar 12, 2024

github-actions bot commented Apr 13, 2024

feat: Allow disabling service creation to support creating just a task definition #176

feat: Allow disabling service creation to support creating just a task definition #176

Conversation

lancedikson commented Mar 3, 2024 • edited Loading

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

bryantbiggs left a comment

Choose a reason for hiding this comment

lancedikson commented Mar 3, 2024 • edited Loading

lancedikson commented Mar 4, 2024

bryantbiggs left a comment

Choose a reason for hiding this comment

lancedikson commented Mar 10, 2024

lancedikson commented Mar 10, 2024

bryantbiggs commented Mar 11, 2024

lancedikson commented Mar 11, 2024

bryantbiggs Mar 12, 2024

Choose a reason for hiding this comment

bryantbiggs Mar 12, 2024

Choose a reason for hiding this comment

bryantbiggs Mar 12, 2024

Choose a reason for hiding this comment

bryantbiggs left a comment

Choose a reason for hiding this comment

antonbabenko commented Mar 12, 2024

github-actions bot commented Apr 13, 2024

lancedikson commented Mar 3, 2024 •

edited

Loading

lancedikson commented Mar 3, 2024 •

edited

Loading