Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update examples to use latest ALB module #130

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Update examples to use latest ALB module
  • Fix variable description for default number of tasks

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

}

target_groups = {
ex-ecs = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use - in keys. I thought tflint complains about such already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it! Updated in c69ba10

examples/fargate/main.tf Outdated Show resolved Hide resolved
bryantbiggs and others added 2 commits November 2, 2023 10:42
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
@bryantbiggs bryantbiggs merged commit 8746b10 into terraform-aws-modules:master Nov 2, 2023
11 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-examples branch November 2, 2023 14:45
@antonbabenko
Copy link
Member

This PR is included in version 5.6.0 🎉

Copy link

github-actions bot commented Dec 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Incorrect default in description of desired_count
2 participants