Uses 2 digits suffixes for instances instead of 1 digit suffix #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the reasoning behind this feature:
While it’s fairly infrequent, it happens to want to create 10+ instances. Even if the actual module will work correctly, names will eventually differ in size. e.g.:
For the sake of cleanliness and to ease the work of system administrator who deals with instances names, this PR would make sure name have the same length:
Now, why not 3 or 4 digits? I think it is very unlikely to have more than 100 instances of the same type and most team would scale vertically or use containers at some point.