Provide a toggle to disable the volume_tags

[dekimsey]

Description

Note, while this works it's a pretty clunky solution. I'm putting this out there as an option.

Currently using this module while also adding a ebs_volume_attachment causes apply churn as the aws_instance's volume_tags conflict with additional tags added outside of the module.

This change introduces a new internal resource that has the lifecycle ignore_changes property set to ignore volume_tags. While clunky, this was the only way to address the volume tag churn.

Perhaps in the future it can be removed if the upstream is able to define a sane way of managing these conflicting entries.

Motivation and Context

Since lifecycle is a dynamic property, we have to create a separate
resource that has this feature disabled. It's not the most graceful
workaround, but it works well enough.

Breaking Changes

The default will keep the current behavior unchanged. Any users who
desire to enable this on existing resources would need to perform a
state mv to avoid replacing resources.

How Has This Been Tested?

I applied the changes on an existing host to verify the move is without issue. I applied by also tainting and re-running.

Related

• Attached EBS Volume tags flip flop between volume_tags for instance on each apply  #164

[dekimsey]

Day after I submit this, the aws provider adds a fix that may address this behavior. Perfect. Scheduled for aws provider v3.24.0

hashicorp/terraform-provider-aws#15474

Closing.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.