Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Serverless replication task support #56

Conversation

gpdenny
Copy link
Contributor

@gpdenny gpdenny commented Jan 17, 2024

Description

Add support for DMS Serverless Replication tasks using aws_dms_replication_config.

  • Add optional creation of a replication instance, default is true to maintain current behaviour
  • Allow setting serverless_config parameters on replication_tasks to make the task a Serverless configuration instead of a replication task

Motivation and Context

resolves #53

Breaking Changes

No breaking changes, default behaviour remains the same.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

Tested using existing and new examples.

  • I have executed pre-commit run -a on my pull request

@gpdenny
Copy link
Contributor Author

gpdenny commented Jan 29, 2024

Hi @antonbabenko @bryantbiggs any thoughts on this one? 🙏

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the link to the example in the README.md in the root.

examples/serverless/main.tf Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
examples/serverless/versions.tf Outdated Show resolved Hide resolved
@gpdenny
Copy link
Contributor Author

gpdenny commented Feb 2, 2024

Thanks for the review @antonbabenko have made the amendments 👍

@antonbabenko antonbabenko merged commit c5fcb29 into terraform-aws-modules:master Feb 2, 2024
8 checks passed
@antonbabenko
Copy link
Member

Thank you @gpdenny !

antonbabenko pushed a commit that referenced this pull request Feb 2, 2024
## [2.2.0](v2.1.0...v2.2.0) (2024-02-02)

### Features

* Add Serverless replication task support ([#56](#56)) ([c5fcb29](c5fcb29))
@antonbabenko
Copy link
Member

This PR is included in version 2.2.0 🎉

@gpdenny gpdenny deleted the serverless-replication-config branch February 2, 2024 21:23
Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do the module support aws_dms_replication_config?
2 participants