Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update aws provider version to restore support for ignore_header_row #41

Closed
wants to merge 6 commits into from

Conversation

scadu
Copy link

@scadu scadu commented Jun 16, 2023

Description

Terraform provider in version 4.49.0 gets a fix that allows setting IgnoreHeaderRows, with a fallback on ignore_header_row besides ignore_header_rows.
In version 5.0.0 of the provider, the fallback is removed and there are many other breaking changes that affects this module and underlying VPC module.

Motivation and Context

Fixes #38

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Fixes terraform-aws-modules#38

Terraform provider in version 4.49.0 gets a fix that allows setting `IgnoreHeaderRows`, with a fallback on `ignore_header_row` besides `ignore_header_rows`.
@scadu scadu changed the title Bump required aws provider version to >= 4.49.0 fix: bump required aws provider version to >= 4.49.0 Jun 16, 2023
@scadu scadu changed the title fix: bump required aws provider version to >= 4.49.0 fix: bump required aws provider version to >= 4.49.0 Jun 16, 2023
@scadu scadu changed the title fix: bump required aws provider version to >= 4.49.0 fix: bump aws provider version to restore support for ignore_header_row Jun 16, 2023
@scadu scadu changed the title fix: bump aws provider version to restore support for ignore_header_row fix: Bump aws provider version to restore support for ignore_header_row Jun 16, 2023
@scadu scadu marked this pull request as ready for review June 16, 2023 10:59
@scadu scadu marked this pull request as draft June 16, 2023 11:33
s3_settings.ignore_headers_row attribute has been removed in aws provider 5.0.0 — https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0
@scadu scadu changed the title fix: Bump aws provider version to restore support for ignore_header_row fix: update aws provider version to restore support for ignore_header_row Jun 16, 2023
@scadu scadu marked this pull request as ready for review June 16, 2023 12:16
@scadu
Copy link
Author

scadu commented Jun 16, 2023

I have no idea why the PR title action fails, even though the title is fine. Looks like the fix prefix isn’t detected for some reason.

@antonbabenko antonbabenko changed the title fix: update aws provider version to restore support for ignore_header_row fix: Update aws provider version to restore support for ignore_header_row Jun 16, 2023
@byjg
Copy link

byjg commented Jun 16, 2023

How do I use your PR in my code?

@scadu
Copy link
Author

scadu commented Jun 16, 2023

How do I use your PR in my code?

You can pin aws provider in your project with the same constraints as in the PR.

@byjg
Copy link

byjg commented Jun 16, 2023

So, I checked the PR files and I realized there is no fix for the Ignore Rows itself, but limiting the terraform to 5.0. I have other terraform-aws they already upgraded the constraints to >5.0.0 and that force me to move to a newer version.

Anyway, thanks for the prompt answer.

@scadu
Copy link
Author

scadu commented Jun 17, 2023

So, I checked the PR files and I realized there is no fix for the Ignore Rows itself, but limiting the terraform to 5.0. I have other terraform-aws they already upgraded the constraints to >5.0.0 and that force me to move to a newer version.

Anyway, thanks for the prompt answer.

I will try to take a look and adjust the module, so it's compatible with aws provider 5.0.0 and above. Let's see.

@scadu
Copy link
Author

scadu commented Jun 17, 2023

With the current example, terraform-aws-modules/terraform-aws-msk-kafka-cluster#4 would need to get merged as EBS-related configuration for aws_msk_cluster resource were also moved.

@igorjanevski
Copy link

Can you guys provide ETA for the fix? We are stuck with this and need it to work with 5.0

@brunodasilvalenga
Copy link

Hey guys, any chances to someone approve the PR?

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 21, 2023
@siourdas-vasilis
Copy link

Any updates on that????

@scadu
Copy link
Author

scadu commented Aug 23, 2023

Looks like #42 is the more complete one, but it's marked as a draft for now.

@antonbabenko
Copy link
Member

This issue has been resolved in version 2.0.0 🎉

@scadu scadu deleted the patch-1 branch August 24, 2023 06:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore_headers_row changed to ignore_header_rows
6 participants