-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update aws provider version to restore support for ignore_header_row #41
Conversation
Fixes terraform-aws-modules#38 Terraform provider in version 4.49.0 gets a fix that allows setting `IgnoreHeaderRows`, with a fallback on `ignore_header_row` besides `ignore_header_rows`.
s3_settings.ignore_headers_row attribute has been removed in aws provider 5.0.0 — https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0
This reverts commit 552e633.
I have no idea why the PR title action fails, even though the title is fine. Looks like the fix prefix isn’t detected for some reason. |
How do I use your PR in my code? |
You can pin aws provider in your project with the same constraints as in the PR. |
So, I checked the PR files and I realized there is no fix for the Ignore Rows itself, but limiting the terraform to 5.0. I have other terraform-aws they already upgraded the constraints to >5.0.0 and that force me to move to a newer version. Anyway, thanks for the prompt answer. |
I will try to take a look and adjust the module, so it's compatible with aws provider 5.0.0 and above. Let's see. |
With the current example, terraform-aws-modules/terraform-aws-msk-kafka-cluster#4 would need to get merged as EBS-related configuration for aws_msk_cluster resource were also moved. |
Can you guys provide ETA for the fix? We are stuck with this and need it to work with 5.0 |
Hey guys, any chances to someone approve the PR? |
This PR has been automatically marked as stale because it has been open 30 days |
Any updates on that???? |
Looks like #42 is the more complete one, but it's marked as a draft for now. |
This issue has been resolved in version 2.0.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Terraform provider in version 4.49.0 gets a fix that allows setting
IgnoreHeaderRows
, with a fallback onignore_header_row
besidesignore_header_rows
.In version 5.0.0 of the provider, the fallback is removed and there are many other breaking changes that affects this module and underlying VPC module.
Motivation and Context
Fixes #38
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request