Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: To allow multiple query strings as an OR statement #383

Merged

Conversation

bdandoy
Copy link
Contributor

@bdandoy bdandoy commented Oct 9, 2024

Description

Fix to allow you to pass multiple query string to load balancer rule

Motivation and Context

We needed to add 2 conditions as an OR statement are the current module did not support it

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bdandoy bdandoy changed the title fix: to allow multiple query strings fix: To allow multiple query strings Oct 9, 2024
@bdandoy bdandoy changed the title fix: To allow multiple query strings fix: fix To allow multiple query strings Oct 9, 2024
@bdandoy bdandoy changed the title fix: fix To allow multiple query strings fix: To allow multiple query strings Oct 9, 2024
@bdandoy bdandoy changed the title fix: To allow multiple query strings fix: To allow multiple query strings as an OR statement Oct 18, 2024
@bdandoy
Copy link
Contributor Author

bdandoy commented Oct 21, 2024

@bryantbiggs can you review?

@bryantbiggs bryantbiggs merged commit 068a578 into terraform-aws-modules:master Oct 22, 2024
11 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 22, 2024
## [9.11.2](v9.11.1...v9.11.2) (2024-10-22)

### Bug Fixes

* To allow multiple query strings as an OR statement ([#383](#383)) ([068a578](068a578))
@antonbabenko
Copy link
Member

This PR is included in version 9.11.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants