Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Sometimes it's necessary to tag target groups at the target group level, rather than just inheriting from the parent ALB.
For example, if we have an ALB for all our QA services, the target groups underneath are tagged with what host group they are. This is useful for if you have heterogenous services running under the same LB. In our case, we have several dev instances that are tagged with their
HostGroup : dev
andIndex: n
for easy filtering on which target groups are available to stick an instance under. I've made these changes for our local fork, but since we'd like to keep upstream changes and avoid conflicts, I figured making this PR would be a good idea. Let me know if this is something you'd like to see in the module!Example:
Checklist
terraform fmt
andterraform validate
both work from the root andexamples/alb_test_fixture
directories (look in CI for an example)Testing notes
Test: https://gist.github.com/snoozan/9d6c494cdfdab8f8427fdb031bf957a8
The RSpec framework being used doesn't spec out tags at the target group level. This could be added to the library, but as of right now, no spec tests were written because of the lack of target group tags. See: k1LoW/awspec@a3e729e#diff-1acc82be899fcf02f9d1974a4850e3f8