Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v2.12 #309

Merged
merged 26 commits into from
Aug 8, 2024
Merged

Prepare for v2.12 #309

merged 26 commits into from
Aug 8, 2024

Conversation

javiersuweijie
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v2.12@cb4a461). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release/v2.12     #309   +/-   ##
================================================
  Coverage                 ?   66.09%           
================================================
  Files                    ?       47           
  Lines                    ?     2280           
  Branches                 ?        0           
================================================
  Hits                     ?     1507           
  Misses                   ?      602           
  Partials                 ?      171           
Files Coverage Δ
app/custom_queriers/custom_queriers.go 100.00% <ø> (ø)
app/upgrade_handler.go 77.58% <100.00%> (ø)
x/tokenfactory/keeper/keeper.go 89.47% <100.00%> (ø)
x/tokenfactory/keeper/msg_server.go 74.43% <50.00%> (ø)
x/tokenfactory/keeper/bankactions.go 51.85% <63.63%> (ø)

Copy link
Contributor

@emidev98 emidev98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the vesting account transformation to basic account works fine. Before merging please remember to add the mainnet addresses to the upgrade handler

@emidev98 emidev98 merged commit ae6333e into release/v2.12 Aug 8, 2024
5 of 6 checks passed
@emidev98 emidev98 deleted the upgrade/v2.12 branch August 8, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants