feat(v2.11): upgrade handler fixing the escrow accounts balances #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidev98
requested review from
javiersuweijie,
tuky191,
gregnuj and
freeelancer
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2.11 #285 +/- ##
=================================================
+ Coverage 70.41% 70.47% +0.05%
=================================================
Files 45 45
Lines 2096 2107 +11
=================================================
+ Hits 1476 1485 +9
- Misses 453 454 +1
- Partials 167 168 +1
|
javiersuweijie
requested changes
Mar 20, 2024
emidev98
force-pushed
the
feat/v2.11/upgrade-handler
branch
from
e213afc
to
01a0aa3
Compare
javiersuweijie
approved these changes
Mar 21, 2024
|
Hey @faddat, are there any other escrows that may not be listed here that we sould check for this upgtrade hanlder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request create the upgrade handler for v2.11 which includes updates to the for PFM's escrow accounts balances due the bug that was spotted for PFM in the previous versions. To calculate the balances we used the following tool at the specified commit: strangelove-ventures/escrow-checker@adf0d86 .
The tool shows two discrepancies the first one on phoenix-1's side and the second discrepancy on the counterpart chain chihuahua-1:
