feat: module version #169
Merged
feat: module version #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/v2.4 #169 +/- ##
================================================
+ Coverage 78.15% 78.18% +0.03%
================================================
Files 4 4
Lines 705 706 +1
================================================
+ Hits 551 552 +1
Misses 140 140
Partials 14 14
|
javiersuweijie
previously approved these changes
Sep 6, 2023
emidev98
force-pushed
the
feat/mod/ver
branch
2 times, most recently
from
d79a759 to
4dd00f8
Compare
tuky191
approved these changes
Sep 7, 2023
javiersuweijie
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a previous commit (a511f8c) the line of code SetModuleVersionMap was deleted by mistake. This causes an error when a new chain is created and wants to be updated because the module versions are not available to upgrade.