Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package: squashfs-tools-ng #6540

Closed
wants to merge 5 commits into from
Closed

Add Package: squashfs-tools-ng #6540

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2021

Fixes (#6537)

First time adding a package for creating/extracting squashfs images, i hope this is okay, and should be usable by everyone

if you have any suggestions/concerns, feel free to ask

@Grimler91
Copy link
Member

Don't put everything in one function. termux_step_make_install() is for make install (or equivalent) only.

Looks like the standard configure, make and make install functions should work, but you do need to run ./autogen.sh before configuring, as you've done. Put that command in termux_step_pre_configure()

@Grimler91
Copy link
Member

Grimler91 commented Mar 19, 2021

Based on the archlinux package page it has some dependencies also

Edit: linked to the wrong package, fixed now.

@ghost
Copy link
Author

ghost commented Mar 19, 2021

Huh, i see, lemme edit it again, thanks anyway

@ghost
Copy link
Author

ghost commented Mar 19, 2021

Hopefully i did it right this time, i never thought that my build.sh is redundant causing problems 😅

@ghost
Copy link
Author

ghost commented Mar 20, 2021

Something went wrong here, i think i need to fix this

@ghost
Copy link
Author

ghost commented Mar 20, 2021

Should i open a new pull request? i probably need to re-fork this repository

@ghost ghost closed this Mar 20, 2021
@ghost
Copy link
Author

ghost commented Mar 20, 2021

Ok, i created another pull request, i hope i shouldn't screw things up this time

@ghost
Copy link

ghost commented Mar 20, 2021

Don't use "master" branch of your fork to create pull requests.

@ghost
Copy link
Author

ghost commented Mar 20, 2021

Huh i see, thanks for the tip, i was playing/messing around with the repo and this happens without my knowledge,

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant