Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.6.14 #8

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Support 1.6.14 #8

merged 1 commit into from
Sep 27, 2023

Conversation

beef331
Copy link
Contributor

@beef331 beef331 commented Sep 26, 2023

Tests pass on 1.6.14 so not much reason not to support it for the time being. Please do make a git tag 😄

@termermc
Copy link
Owner

Docs won't generate on 1.6.14 unless uses of addr are replaced with unsafeAddr. Isn't that feature deprecated?

@beef331
Copy link
Contributor Author

beef331 commented Sep 26, 2023

Ugh more work is required, seemed so easy to add 1.6.14 support.

@termermc
Copy link
Owner

termermc commented Sep 26, 2023

If it's not a deprecated feature, unsafeAddr can be used in place of addr. If it is, a few when blocks can be used. It's not a big set of changes, and everything still passes on my testing with unsafeAddr.

@termermc
Copy link
Owner

Oh yeah, looks like it was deprecated: nim-lang/RFCs#369
So when can be added to the code and runnableExamples blocks without issue.

@beef331
Copy link
Contributor Author

beef331 commented Sep 26, 2023

Yea I knew how to fix it of course, I just didnt want to have to go through and do it 😛

@termermc
Copy link
Owner

The only things that need to be updated now are the README to remove the inaccurate bit about 2.0.0 support, and runnableExamples, the latter of which could have comments explaining unsafeAddr being required pre-2.0.0

@termermc termermc merged commit d080142 into termermc:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants