Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep match with higher level siblings #44

Merged
merged 1 commit into from
Apr 21, 2019

Conversation

RedHatter
Copy link
Contributor

@RedHatter RedHatter commented Apr 12, 2019

The level parameter was being incremented at each loop iteration instead of only inside of a new walk call. So for example

├── a          <- level 0
├── b          <- level 1 (should be 0)
│   ├── c      <- level 2 (should be 1)

@terkelg
Copy link
Owner

terkelg commented Apr 12, 2019

Thank you so much @RedHatter – I'll merge this over the weekend

@benmccann
Copy link
Contributor

This PR is causing two tests to fail:

  glob: glob
    ✖ should be equivalent
    -----------------------
      operator: deepEqual
      expected: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      actual: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/deep', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      at: <anonymous> (test/glob.js:11:7)
      stack: |-
  glob: options.filesOnly
    ✖ should be equivalent
    -----------------------
      operator: deepEqual
      expected: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      actual: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/deep', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      at: <anonymous> (test/glob.js:11:7)
      stack: |-

This was referenced Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants