Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect: Change BeanMapper from Dozer to MapStruct #525

Closed
3 tasks done
btonokit opened this issue Sep 9, 2022 · 3 comments
Closed
3 tasks done

Reflect: Change BeanMapper from Dozer to MapStruct #525

btonokit opened this issue Sep 9, 2022 · 3 comments

Comments

@btonokit
Copy link
Contributor

btonokit commented Sep 9, 2022

Original Issue

Links to the original issues.

Description

Please write if the description of the original issue is not enough.
Please write based on facts as much as possible, and post links to references/Javadoc or stack traces.

Possible Solution

Please write ideas or candidates of solutions for the problem if you have.
If it is an example, please enter a description such as "For example".

  • Remove Dozer configuration from applicationContext.xml
  • Remove dozer.poperties
  • Add .factorypath to .gitignore
    • .factorypath is a file generated by eclipse and used for annotation processing.
      In other words, it does not need to be managed by Git.

Fix repositories

Repositories to fix with this issue.

  • terasoluna-gfw-web-blank
  • m-j
  • m-t

Issue links

Links to related issues.

  • #xx
@yoshikawaa
Copy link
Contributor

https://mapstruct.org/faq/#Can-I-use-MapStruct-together-with-Project-Lombok

You can provide setting mock for using MapStruct+Lombok.

https://mapstruct.org/documentation/stable/reference/html/#configuration-options

You can provide mapstruct.defaultComponentModel=spring for auto wiring. (Blank or Parent)

@btonokit
Copy link
Contributor Author

btonokit commented Sep 13, 2022

You can provide setting mock for using MapStruct+Lombok.
You can provide mapstruct.defaultComponentModel=spring for auto wiring. (Blank or Parent)

After discussion, it was decided to set both to gfw-parent.

btonokit added a commit that referenced this issue Sep 15, 2022
btonokit added a commit that referenced this issue Sep 15, 2022
btonokit added a commit that referenced this issue Sep 15, 2022
btonokit added a commit that referenced this issue Sep 15, 2022
@btonokit
Copy link
Contributor Author

Since it is completely up to the user whether to use Lombok or MapStruct, we concluded that it would be better to allow the user to choose in a blank project.

terasolunaorg/terasoluna-gfw#1184 (comment)
terasolunaorg/terasoluna-gfw#1184 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants