Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank eclipse project (WTP) puts runtime scoped libraries in wrong directory. #437

Closed
1 task done
yoshikawaa opened this issue Jun 26, 2020 · 3 comments
Closed
1 task done

Comments

@yoshikawaa
Copy link
Contributor

yoshikawaa commented Jun 26, 2020

Description

##-------------------------
## download jars
##-------------------------
download_jars() {
rm -rf $WEBINFLIB $LIBSRC $TESTLIB
mvn dependency:copy-dependencies -DoutputDirectory=$WEBINFLIB -DincludeScope=compile -DexcludeScope=provided -DexcludeTypes=pom
mvn dependency:copy-dependencies -DoutputDirectory=$LIBSRC -DincludeScope=compile -DexcludeScope=provided -DexcludeTypes=pom -Dclassifier=sources
mvn dependency:copy-dependencies -DoutputDirectory=$TESTLIB -DexcludeScope=compile -DexcludeTypes=pom
mvn dependency:copy-dependencies -DoutputDirectory=$LIBSRC -DexcludeScope=compile -DexcludeTypes=pom -Dclassifier=sources
echo $? > /dev/null
}

WEB-INF/lib, libsrc directory must contain compile and runtime scoped jars, but does not actually include runtime scoped jars.
Conversely, the testlib directory should not contain compile and runtime scoped jars, but actually contains runtime scoped jars.

Note:
This issue is not affect multi-module projects, because it is not provide the Blank eclipse project (WTP).

Possible Solution

Please write ideas or candidates of solutions for the problem if you have.
If it is an example, please enter a description such as "For example".

Affect versions

Version in which the problem occurs. Current version if not known.
If there is a feature suggestion, please delete it.

  • 5.5.1.RELEASE and earlier all versions.

Fix repositories

Repositories to fix with this issue.

  • terasoluna-gfw-web-blank

Issue links

Links to related issues.

  • #xx
btkobayashirun added a commit that referenced this issue Jun 26, 2020
btkobayashirun added a commit that referenced this issue Jun 26, 2020
btkobayashirun added a commit that referenced this issue Jun 29, 2020
btkobayashirun added a commit that referenced this issue Jun 29, 2020
yoshikawaa pushed a commit that referenced this issue Jun 29, 2020
* fix scope compile from to runtime in shell of making wtp #437

* remove not working option #437

* fix unification of options #437

* remove option for libsrc setting #437

* remove duplicate commands #437

* fix the deletion order according to the mvn commands #437
@yoshikawaa
Copy link
Contributor Author

Please close after considering whether to need or not backport.

@takahashihrzg
Copy link

The scope of the backport will be determined in future discussions.

@yoshikawaa
Copy link
Contributor Author

yoshikawaa commented Jul 2, 2020

The scope of the backport will be determined in future discussions.

In terms of quality, it's better to backport to all maintenance versions since 1.0.x due to a fatal non-bootable bug.
In terms of release, it is unknown which version is subject to normal maintenance, emergency maintenance, or EOL, and it is necessary to consider it.

I've given the backport label so that we can see that it's needed to backport after selecting a release target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants