Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-65: Improve test assertions #429

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

Abigael-JT
Copy link
Contributor

@Abigael-JT Abigael-JT commented Nov 21, 2024

Updated expectedSchema in assertions to be created from java objects

Updated schema assertions to use java objects

Fixes for:

Related PR:

@Abigael-JT Abigael-JT self-assigned this Nov 28, 2024
@Abigael-JT Abigael-JT changed the title issue-65 issue-65: Improve test assertions Dec 5, 2024
@Abigael-JT Abigael-JT marked this pull request as ready for review December 5, 2024 15:11
@Abigael-JT Abigael-JT requested a review from eemhu December 5, 2024 15:11
@Abigael-JT Abigael-JT requested a review from eemhu December 12, 2024 14:32
@kortemik
Copy link
Member

Please rebase for merge.

@Abigael-JT
Copy link
Contributor Author

rebase done

Copy link
Member

@kortemik kortemik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an excellent one, thank you!

@kortemik kortemik merged commit b52fda4 into teragrep:main Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants