Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotless #300

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Spotless #300

merged 3 commits into from
Sep 2, 2024

Conversation

kortemik
Copy link
Member

@kortemik kortemik commented Sep 2, 2024

first commit adds spotless, second one applies it.

please conduct the review as follows:

Github uses format-patch with different options, so it may be preferable to push ones locally applied branch to one's own github fork and generate and download a patch from there. it should only have a header change. alternative is to just review the files.

@StrongestNumber9
Copy link
Contributor

Preliminary check ok, waiting for mvn to finish

@StrongestNumber9
Copy link
Contributor

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.15:check (default) on project pth_10: Too many files with unapproved license: 339 See RAT report in:

License failure

Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied first patch, ran spotless:apply and verified diffs to be correct, applied third patch and executed properly

@StrongestNumber9 StrongestNumber9 merged commit 21d96c9 into teragrep:main Sep 2, 2024
@StrongestNumber9 StrongestNumber9 mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants