Remove unnecessary equals and hashcode tests #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 .
Coverity flagged an equality test in ImmutableMapTest.java because of an unnecessary method call. Removing just that line makes the equality test quite unnecessary itself as the function call was there to check for side-effects.
My thought process here:
Added bonus:
Coverity won't flag other tests in the future, because many other equality tests had similar unnecessary function calls but for some reason they were not flagged yet.
TLDR:
Equalsverifier is used in the project, so manual equality tests are not necessary. Coverity had flagged one of the manual tests, might flag more later.