Support System Properties as a configuration source #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliVM
requested changes
Nov 12, 2024
|
@51-code please rebase |
Update README Support system properties as a configuration source
… class variable, refine tests
kortemik
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6 .
Adds support for System Properties. Changing properties after the constructor call doesn't have effect on the object as the Properties are immediately made an unmodifiable map.
Configurations with Properties can't really fail so the asMap() function doesn't throw here, using DefaultConfigurations by passing in PropertiesConfiguration would therefore be pointless.
README additions this time too.