This repository has been archived by the owner on May 29, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 16
Use optional dependencies for different MISP integrations #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@satta fyi 😉 that should simplify the dependency management! |
That sounds great! 👍 |
lava
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a lot of context to be able to comment on the contents, but the code looks reasonable.
rolandpeelen
approved these changes
Feb 23, 2021
Looks good, will test once we upgrade to the latest version everywhere. Not sure how I would test this |
@satta you can simply do |
Ah thanks! I tried |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Attributes can either be exported from MISP via ZeroMQ or via Kafka. The MISP plugin supports both, but also used to force the user to have both dependencies installed.
This PR eliminates the need to install both dependencies by using extra dependencies (PEP 508). This breaks how the plugin is installed:
A plain
pip install threatbus-misp
without specifying the extras option works, but the plugin will throw a critical error during config validation and terminate right after.📝 Checklist
🎯 Review Instructions
Commit-by-commit.