Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Rename ZMQ plugin #157

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Rename ZMQ plugin #157

merged 4 commits into from
Aug 9, 2021

Conversation

mavam
Copy link
Member

@mavam mavam commented Aug 6, 2021

📔 Description

The PR renames the ZeroMQ plugin from zmq-app to zmq. For one, the dash caused bugs in combination with Dynaconf and configuration (zmq-app vs zmq_app). Moreover, the suffix -app is a bit confusing because it's technically a plugin.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/threatbus, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

TBD

mavam added 2 commits August 6, 2021 11:23
This causes a silent failure of Dynaconf to load the respective config
settings.
@lava
Copy link
Member

lava commented Aug 6, 2021

Maybe we can use this PR for renaming pyvast-threatbus -> vast-threatbus as well, if we're doing breaking changes anyways.

@mavam mavam requested a review from lava August 6, 2021 13:03
@dominiklohmann
Copy link
Member

Maybe we can use this PR for renaming pyvast-threatbus -> vast-threatbus as well, if we're doing breaking changes anyways.

I'll do that in a separate PR so we have an easier time adapting downstream.

@lava lava marked this pull request as ready for review August 9, 2021 09:32
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are just mechanical, and we already verified experimentally that we didn't miss anything.

Note to self: We need to publish the package under the new name to PyPi when merging this.

@lava lava merged commit dea09d2 into master Aug 9, 2021
@lava lava deleted the story/ch27701 branch August 9, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants