-
-
Notifications
You must be signed in to change notification settings - Fork 15
Rewrite Zeek plugin to convert to/from STIX-2 Indicators and Sightings #103
Conversation
This pull request introduces 2 alerts when merging 5ac2124 into 1ba54e7 - view on LGTM.com new alerts:
|
03f3bd0
to
4e940bc
Compare
This pull request introduces 2 alerts when merging 5cba369 into bf33351 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 90b452f into a082f2d - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 73b3762 into a082f2d - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b4d40a5 into a082f2d - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b4d40a5 into 5ad3665 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 67c46e0 into 5ad3665 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging ce57817 into 5ad3665 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and can vouch that sightings are logged from threatbus when zeek detects them.
I didn't do a very thorough code review, most of it is in tests which are repetitive by nature. I only have a few suggestions and questions which can be resolved by adding comments.
Co-authored-by: tobim <tobim@fastmail.fm>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again with the latest changes. Everything seems to work as expected.
📔 Description
Following up on the STIX-2 rewrite of Threat Bus: this PR updates the Zeek plugin.
📝 Checklist
🎯 Review Instructions
Do at least a code-review & run the unit tests. If you want to try out more, here is how:
Integration testing:
You require a local Broker installation with Python bindings for integration testing
Interactive usage:
You require local Zeek and Broker installations with Python bindings for interactive usage
sudo zeek -i wlp0s20f3 -C apps/zeek/threatbus.zeek
)example.com
.curl
or similar to invokeexample.com
-> Zeek should match that immediately, report a Sighting to Threat Bus and that should be logged as valid STIX-2 (debug logging)