Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR adds minimal configurability to the rotating file sink used for spdlog.
It adds the option
vast.log-rotation
to turn off rotation, which is required for production use where VAST's log rotation may interfere with log rotation configured in external programs like systemd or logrotated.The size threshold, number of rotated log files, and whether to use time-based logrotate are not made configurable, since we did not have anyone asking for these features yet.
📝 Checklist
🎯 Review Instructions