Require fmt to be installed separately from spdlog #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
story/ch22336/formatter-improvements
to
master
February 2, 2021 09:24
lava
reviewed
Feb 2, 2021
dominiklohmann
force-pushed
the
story/ch22402/external-fmt
branch
2 times, most recently
from
53e92d9
to
f910763
Compare
dominiklohmann
force-pushed
the
story/ch22402/external-fmt
branch
2 times, most recently
from
1259a7a
to
2a8a117
Compare
lava
reviewed
Feb 2, 2021
dominiklohmann
force-pushed
the
story/ch22402/external-fmt
branch
from
f4e376d
to
2a8a117
Compare
lava
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Looks good to me. Although I think the stated reasons (ie. verbosity in the include statements) are a bit weak for adding a new hard dependency, in this case it should be fine since we more or less depended on fmt anyways via spdlog, and it is a "nice" dependency to have since it's stable, useful and available everywhere.
The rest of the changes look solid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This makes {fmt} a hard dependency of VAST, and fixes some of the remaining issues with the new logger.
📝 Checklist
🎯 Review Instructions
Commit-by-commit.