#13065: Use the same action for building and running #13066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri-tenstorrent
requested review from
tt-rkim,
ttmchiou and
TT-billteng
as code owners
| @@ -80,12 +80,9 @@ jobs: | |||
| timeout-minutes: ${{ inputs.timeout }} | |||
| uses: ./.github/actions/docker-run | |||
| with: | |||
| docker_username: ${{ github.actor }} | |||
| install_wheel: true | |||
There was a problem hiding this comment.
Missed this in the code rebase
| @@ -80,7 +80,7 @@ runs: | |||
| ${{ inputs.device }} | |||
| -w ${{ github.workspace }} | |||
| run: | | |||
| if [ ${{ inputs.install_wheel }} ]; then | |||
| if [ ${{ inputs.install_wheel }} = "true" ]; then | |||
There was a problem hiding this comment.
Need to use as a string comparison - the value is not actually boolean. There is an existing Github issue:
There was a problem hiding this comment.
does it matter if its "" or ''?
I didn't realize this was a thing so maybe we should double check if we have other comparisons here too
There was a problem hiding this comment.
I think both "" and '' evaluate to a string in bash so it does not matter.
Do you think '' is more consistent?
There was a problem hiding this comment.
i think as long as we stick to one convention it is fine.
dimitri-tenstorrent
temporarily deployed
to
dev
GitHub Actions
Inactive
dimitri-tenstorrent
temporarily deployed
to
dev
GitHub Actions
Inactive
dimitri-tenstorrent
temporarily deployed
to
dev
GitHub Actions
Inactive
dimitri-tenstorrent
temporarily deployed
to
dev
GitHub Actions
Inactive
dimitri-tenstorrent
force-pushed
the
dimitri/13065-use-a-single-docker-run-for-building-and-running-tests
branch
from
b0a21f0 to
7d37bcc
Compare
dimitri-tenstorrent
force-pushed
the
dimitri/13065-use-a-single-docker-run-for-building-and-running-tests
branch
from
7d37bcc to
b4c93a0
Compare
ttmchiou
approved these changes
Oct 3, 2024
tt-rkim
approved these changes
Oct 16, 2024
dimitri-tenstorrent
deleted the
dimitri/13065-use-a-single-docker-run-for-building-and-running-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#13065
Problem description
We were working at the same time and solving similar issues from different angles resulting in very similar solutions.
Docker Run Action
tt-metal/.github/actions/docker-run/action.yml
Line 56 in cef5730
Docker Run Action in Build Step
tt-metal/.github/workflows/build-artifact.yaml
Line 100 in cef5730
What's changed
The actions are actually near identical and so the generic Docker Run Action just needs to be incorporated into the build step.
Couple of other fixes:
Checklist