Generate static TfLiteEvalTensors #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR generates all of the TfLiteEvalTensors for the graph. It also generates all of the static buffers used for tensors that were present in the flatbuffer. BUG=b/295077140
advaitjain
reviewed
Aug 28, 2023
codegen/utils.py
Outdated
Comment on lines
39
to
42
| chunk = tuple(itertools.islice(data_iterator, chunk_size)) | ||
| while chunk: | ||
| yield chunk | ||
| chunk = tuple(itertools.islice(data_iterator, chunk_size)) |
There was a problem hiding this comment.
this reads a bit funny.
Is there any way to write this where the loop looks something like:
while <not sure what the condition would be>:
chunk = tuple(itertools.islice(data_iterator, chunk_size))
yield chunkThere was a problem hiding this comment.
WDYT of this:
while True:
chunk = tuple(itertools.islice(data_iterator, chunk_size))
if not chunk:
break
yield chunk
There was a problem hiding this comment.
+1. that seems more readable to me.
advaitjain
requested changes
Aug 28, 2023
advaitjain
approved these changes
Aug 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates all of the TfLiteEvalTensors for the graph. It also generates all of the static buffers used for tensors that were present in the flatbuffer.
BUG=b/295077140