Adds FFT Auto Scale Op #2134
Merged
Adds FFT Auto Scale Op #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rascani
reviewed
Jul 18, 2023
| in_frame = np.array([int(j) for j in lines[i].split()], dtype=np.int16) | ||
| out_frame_exp = [int(j) for j in lines[i + 1].split()] | ||
| scale_exp = [int(j) for j in lines[i + 2].split()] | ||
| # TFLite |
There was a problem hiding this comment.
Done. Changed to TFLM, but we have a TODO elsewhere to revisit these tests in general when we get the chance.
| #include "signal/src/msb.h" | ||
|
|
||
| // TODO(b/286250473): remove namespace once de-duped libraries | ||
| namespace tflm_signal { |
There was a problem hiding this comment.
Can we put this in tflite::tflm_signal? When we remove the namespace, we don't want the symbol to wind up in the global namespace.
There was a problem hiding this comment.
Done. I wonder if we can remove the tflm_signal anyways then, or just reword it to tflite when we de-dupe?
signal/src/fft_auto_scale.cc
Outdated
| namespace tflm_signal { | ||
|
|
||
| int FftAutoScale(const int16_t *input, int size, int16_t *output) { | ||
| const int16_t max = tflm_signal::MaxAbs16(input, size); |
There was a problem hiding this comment.
The tflm_signal:: prefix shouldn't be necessary here or line 29, as we're already in that namespace.
| #include "signal/src/max_abs.h" | ||
|
|
||
| // TODO(b/286250473): remove namespace once de-duped libraries | ||
| namespace tflm_signal { |
There was a problem hiding this comment.
Same comment here about putting it in the tflite::tflm_signal namespace.
rascani
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional FFT op functionality in the Signal library, namely adding the FFT Auto Scale operation.
Testing added in the original
fft_test.ccandfft_ops_test.py.BUG=287346710