Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to include the repository #5770

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

v-rr
Copy link
Contributor

@v-rr v-rr commented Oct 26, 2021

Hi there!
This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process.
We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on npmjs.com against the metadata in the package.json file in the repository.
This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include @s-tuli, @iarna, @rancyr, @Jaydon Peng, @Zhongpeng Zhou and @Jingying Gu). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: microsoft/Secure-Supply-Chain
This PR provides repository metadata for the following packages:

  • @tensorflow/tfjs-react-native
  • @tensorflow/tfjs-layers
  • @tensorflow/tfjs-data
  • @tensorflow/tfjs-backend-wasm

This change is Reviewable

Hi there!
This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process.
We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on [npmjs.com](www.npmjs.com) against the metadata in the package.json file in the repository.
This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include [@s-tuli](https://github.com/s-tuli), [@iarna](https://github.com/iarna), [@rancyr](https://github.com/v-rr), [@jaydon Peng](https://github.com/v-jiepeng), [@zhongpeng Zhou](https://github.com/v-zhzhou) and [@jingying Gu](https://github.com/v-gjy)). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: [microsoft/Secure-Supply-Chain](https://github.com/microsoft/Secure-Supply-Chain)
This PR provides repository metadata for the following packages:
* @tensorflow/tfjs-react-native
* @tensorflow/tfjs-layers
* @tensorflow/tfjs-data
* @tensorflow/tfjs-backend-wasm
@google-cla
Copy link

google-cla bot commented Oct 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@v-rr
Copy link
Contributor Author

v-rr commented Nov 23, 2021

Individual CLA has been signed. Please let me know if there is anything additional needed from me to land this Pull Request.

@v-rr
Copy link
Contributor Author

v-rr commented Nov 23, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 23, 2021
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@mattsoulanille mattsoulanille merged commit 694c6e2 into tensorflow:master Nov 23, 2021
mattsoulanille added a commit to mattsoulanille/tfjs that referenced this pull request Nov 23, 2021
Add the "repository" field to packages that were missing it and update the field for packages that were migrated into the monorepo. See tensorflow#5770 for details on why this is being done.
mattsoulanille added a commit to mattsoulanille/tfjs that referenced this pull request Nov 23, 2021
Add the "repository" field to packages that were missing it and update the field for packages that were migrated into the monorepo. See tensorflow#5770 for details on why this is being done.
mattsoulanille added a commit that referenced this pull request Nov 23, 2021
Add the "repository" field to packages that were missing it and update the field for packages that were migrated into the monorepo. See #5770 for details on why this is being done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants