Relaxes restriction on protobuf dep since issue was fixed. #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groszewn
approved these changes
Oct 23, 2023
arcra
added a commit
that referenced
this pull request
Feb 2, 2024
I should have added this condition in #6660. At the time I thought it wouldn't matter much, as I assumed users would most likely get a newer version installed, but on second thought, it would be better to have this check, just in case.
|
Sorry for the late reply, @wenfeiy-db , we were waiting for our regular release that follows TensorFlow's schedule, but their release has been delayed a bit, so I ended up creating a patch release v2.15.2 with this dependency change. Let us know if you find any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocolbuffers/protobuf#13485 was fixed with protocolbuffers/upb#1514, so this shouldn't be an issue anymore.
If CI passes successfully with this change, then it should be fine to merge.