New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 compatibility issue #5453

Closed

ryanwcyin wants to merge 2 commits into tensorflow:master from ryanwcyin:patch-1

ryanwcyin commented Oct 8, 2018

Fixed python3 compatibility issue #4780


          python3 compatibility issue

cc37488

Fixed python3 compatibility issue tensorflow#4780

ryanwcyin requested review from derekjchow, jch1 and pkulzc as code owners

October 8, 2018 14:02

googlebot added the cla: yes label

rob-white reviewed

View reviewed changes

research/object_detection/model_lib.py Outdated

@@ @@ -410,8 +411,9 @@ def tpu_scaffold(): @@
                           eval_dict)
                     # Eval metrics on a single example.
+                    category_index_values = category_index.values() if sys.version_info[0] < 3 elses list(category_index.values())

rob-white Oct 11, 2018

Currently throws a syntax error:

Change elses to else


          Corrected typo

28f676d

`elses` -> `else`

Author

ryanwcyin commented Oct 11, 2018

@rob-white Thanks for the reminder! the typo is fixed:)

Contributor

cclauss commented Oct 22, 2018

Two other Python 3 issues in object_detection...

flake8 testing of https://github.com/tensorflow/models on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./research/object_detection/dataset_tools/oid_hierarchical_labels_expansion.py:157:55: E999 SyntaxError: invalid syntax
    print '--annotation_type expected value is 1 or 2.'
                                                      ^
./research/object_detection/utils/object_detection_evaluation.py:307:27: F821 undefined name 'unicode'
          category_name = unicode(category_name, 'utf-8')
                          ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'unicode'
89

5 similar comments

Contributor

cclauss commented Oct 22, 2018

Two other Python 3 issues in object_detection...

flake8 testing of https://github.com/tensorflow/models on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./research/object_detection/dataset_tools/oid_hierarchical_labels_expansion.py:157:55: E999 SyntaxError: invalid syntax
    print '--annotation_type expected value is 1 or 2.'
                                                      ^
./research/object_detection/utils/object_detection_evaluation.py:307:27: F821 undefined name 'unicode'
          category_name = unicode(category_name, 'utf-8')
                          ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'unicode'
89

Contributor

cclauss commented Oct 22, 2018

Two other Python 3 issues in object_detection...

flake8 testing of https://github.com/tensorflow/models on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./research/object_detection/dataset_tools/oid_hierarchical_labels_expansion.py:157:55: E999 SyntaxError: invalid syntax
    print '--annotation_type expected value is 1 or 2.'
                                                      ^
./research/object_detection/utils/object_detection_evaluation.py:307:27: F821 undefined name 'unicode'
          category_name = unicode(category_name, 'utf-8')
                          ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'unicode'
89

Contributor

cclauss commented Oct 22, 2018

Two other Python 3 issues in object_detection...

flake8 testing of https://github.com/tensorflow/models on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./research/object_detection/dataset_tools/oid_hierarchical_labels_expansion.py:157:55: E999 SyntaxError: invalid syntax
    print '--annotation_type expected value is 1 or 2.'
                                                      ^
./research/object_detection/utils/object_detection_evaluation.py:307:27: F821 undefined name 'unicode'
          category_name = unicode(category_name, 'utf-8')
                          ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'unicode'
89

Contributor

cclauss commented Oct 22, 2018

Two other Python 3 issues in object_detection...

flake8 testing of https://github.com/tensorflow/models on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./research/object_detection/dataset_tools/oid_hierarchical_labels_expansion.py:157:55: E999 SyntaxError: invalid syntax
    print '--annotation_type expected value is 1 or 2.'
                                                      ^
./research/object_detection/utils/object_detection_evaluation.py:307:27: F821 undefined name 'unicode'
          category_name = unicode(category_name, 'utf-8')
                          ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'unicode'
89

Contributor

cclauss commented Oct 22, 2018

Two other Python 3 issues in object_detection...

flake8 testing of https://github.com/tensorflow/models on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./research/object_detection/dataset_tools/oid_hierarchical_labels_expansion.py:157:55: E999 SyntaxError: invalid syntax
    print '--annotation_type expected value is 1 or 2.'
                                                      ^
./research/object_detection/utils/object_detection_evaluation.py:307:27: F821 undefined name 'unicode'
          category_name = unicode(category_name, 'utf-8')
                          ^
1     E999 SyntaxError: invalid syntax
1     F821 undefined name 'unicode'
89

jaeyounkim assigned jch1

Collaborator

jaeyounkim commented Apr 25, 2020

Fixed

jaeyounkim closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels