Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifications for bigquery connector #1492

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Clarifications for bigquery connector #1492

merged 4 commits into from
Aug 5, 2021

Conversation

vlasenkoalexey
Copy link
Contributor

  • Added code snippet describing how to get better performance when reading data from BQ with large batch sizes or wide rows
  • Clarified meaning of the requested_streams argument

kvignesh1420
kvignesh1420 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@kvignesh1420 kvignesh1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vlasenkoalexey

yongtang
yongtang approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @vlasenkoalexey

@yongtang yongtang merged commit 9c2c9d6 into tensorflow:master Aug 5, 2021
dopiera pushed a commit to Unoperate/tensorflow_io that referenced this pull request Dec 3, 2021
@vlasenkoalexey
Clarifications for bigquery connector (tensorflow#1492)
7fd8f67 
* some clarifications for bigquery connector

* rephrased API comment

* added referenced to dataset.cache() API

* fixed typos in the doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvignesh1420 kvignesh1420 kvignesh1420 approved these changes

@yongtang yongtang yongtang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlasenkoalexey @yongtang @kvignesh1420