-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Pickle Protocol for Keras #286
Conversation
resolved |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
62d98dc
to
960af33
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cc @mihaimaruseac for initial review |
It seems there are no more comments. Let's schedule an internal review then. I'll come back with the date. |
Design review scheduled for 22nd of October at 10am Pacific Time. |
Awesome, thank you! |
|
||
This RFC would resolve these issues. | ||
|
||
## Design Proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the list of base classes that you expect will need to implement the __reduce__
method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a good starting point would be:
tf.keras.Model
tf.keras.metrics.Metric
tf.keras.losses.Loss
tf.keras.optimizers.Optimizer
tf.keras.callbacks.Callback
I think layers are usually serialized as part of a Model
; I don't think there's much of a use case for implementing __reduce__
for individual layers.
But generally, all classes that already have a serialize
and deserialize
method could benefit getting a __reduce__
that just references those, but there is no reason why they have all be implemented together (or at all).
That's at 3-4PM Pacific time. Sorry for any confustion. |
Notes from the design meeting:
Conclusions:
|
Great to see this in! Thanks all! 😄 👏 |
Comment period is open until 10-13.
As per discussion in tensorflow/tensorflow#39609 (comment)
Objective
Implement support for Pickle, Python's serialization protocol within Keras.