Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Addons for python3.7 #75

Closed
seanpmorgan opened this issue Mar 6, 2019 · 10 comments · Fixed by #389
Closed

Package Addons for python3.7 #75

seanpmorgan opened this issue Mar 6, 2019 · 10 comments · Fixed by #389
Assignees
Labels

Comments

@seanpmorgan
Copy link
Member

Using the current docker image, we're unable to install / build TensorFlow in python3.7 with the following error:

ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /root/miniconda2/envs/py37/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so)

It seems like we need to compile using Ubuntu 16.04 libs, which will require a bump in the custom-op docker image. @yifeif would it be possible to bump the base image in the container? If so we can rebuild our release as 0.1.1 and include py37.

Alternatively, we could create a new docker image for builds.

@seanpmorgan seanpmorgan added bug Something isn't working build labels Mar 6, 2019
@facaiy
Copy link
Member

facaiy commented Mar 16, 2019

@dynamicwebpaige Paige, tf-2.0-preview has supported python 3.7 in tensorflow/tensorflow#25429 . Could you tell us how did you do it?

@seanpmorgan
Copy link
Member Author

cc @gunan. Is ubuntu 14.04 being used for the build or some other docker image?

@gunan
Copy link

gunan commented Mar 19, 2019

For python 3.7, we had to base our builders off of ubuntu 16.04.
Everything else uses ubuntu 14.04

@yifeif
Copy link

yifeif commented Mar 19, 2019

We will definitely need a new image for python3.7.

@seanpmorgan

This comment has been minimized.

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Apr 2, 2019

Bumping to ubuntu16+GCC5 caused issues issues as seen here in the most recent builds of TF:
tensorflow/tensorflow#27067

This will remain unsolved until the manylinux2010 toolchain is finalized. See #119

@hartikainen
Copy link

What's the ETA for tf addons python 3.7 support?

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Jul 22, 2019

@perfinion is there an ETA for the updated build environment / ETA when TF pip packages will be built in it? Just for reference python 3.8 release is soon.

@seanpmorgan
Copy link
Member Author

Looks like this is almost ready:
tensorflow/tensorflow@ec83c8a

@av8ramit Could you comment on the above question?

@av8ramit
Copy link
Contributor

Ideally worst case within two weeks we will transition over. Waiting on one last issue with GPU custom ops.

@seanpmorgan seanpmorgan removed the blocked Pending something elses completion label Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants