feat: support veci8 #326

my-vegetable-has-exploded · 2024-01-31T07:34:49Z

close #196

veci8 use i8 as element type.

crates/service/src/prelude/global/i8_cos.rs

VoVAllen

Please fix the CI with the DCO signoff
Resolve the conflicts
Add some tests for the int8 calculation/conversion, and end2end SQL tests

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

VoVAllen · 2024-02-25T13:09:22Z

Please resolve the conflicts

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

crates/base/src/global/veci8.rs

crates/base/src/lib.rs

crates/detect/src/x86_64.rs

src/datatype/memory_veci8.rs

crates/base/src/vector/veci8.rs

src/datatype/memory_veci8.rs

usamoi · 2024-02-28T14:18:33Z

Okay.

________________________________ From: yi wang ***@***.***> Sent: Wednesday, February 28, 2024 8:54:49 PM To: tensorchord/pgvecto.rs ***@***.***> Cc: usamoi ***@***.***>; Comment ***@***.***> Subject: Re: [tensorchord/pgvecto.rs] feat: support veci8 (PR #326) @my-vegetable-has-exploded commented on this pull request.

________________________________ In crates/base/src/lib.rs<#326 (comment)>:

@@ -1,5 +1,6 @@

#![feature(core_intrinsics)] #![feature(avx512_target_feature)] +#![feature(stdsimd)] I think this feature is removed a few days ago. Let's update toolchain. We are currently stuck with toolchain 2024-01-14， maybe we can remove it later? — Reply to this email directly, view it on GitHub<#326 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS426HU54FI7TZE7OR5CX5DYV4SJTAVCNFSM6AAAAABCSRYT62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBWGE4TQMJYGU>. You are receiving this because you commented.Message ID: ***@***.***>

fix dot_vnni add more tests for similarity. Add sum and l2_norm for Veci8Header. fix other comments. Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

my-vegetable-has-exploded · 2024-02-28T15:33:35Z

Thanks for review.

Since tests for vnni need specific support, I didn't add it into tests. You can check it here https://github.com/my-vegetable-has-exploded/dot-bench.

usamoi · 2024-02-29T00:10:28Z

Since tests for vnni need specific support, I didn't add it into tests.

You can add tests that only run on specific targets.

ref:
https://github.com/tensorchord/pgvecto.rs/blob/main/crates/c/tests/x86_64.rs

VoVAllen · 2024-02-29T04:39:15Z

is this ready for review?

my-vegetable-has-exploded · 2024-02-29T04:54:06Z

is this ready for review?

yes.

src/sql/finalize.sql

src/datatype/text_veci8.rs

crates/base/src/global/veci8.rs

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

src/sql/finalize.sql

usamoi · 2024-03-01T08:59:39Z

Could you submit a PR to update the document (mainly schema.md) in https://github.com/tensorchord/pgvecto.rs-docs?

my-vegetable-has-exploded · 2024-03-01T10:04:08Z

Could you submit a PR to update the document (mainly schema.md) in https://github.com/tensorchord/pgvecto.rs-docs?

sure

src/sql/finalize.sql

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

Signed-off-by: usamoi <usamoi@outlook.com>

my-vegetable-has-exploded · 2024-03-04T07:13:08Z

Thanks all!

VoVAllen mentioned this pull request Feb 1, 2024

add 2024Jan benchmark tensorchord/pgvecto.rs-docs#39

Merged

VoVAllen reviewed Feb 5, 2024

View reviewed changes

crates/service/src/prelude/global/i8_cos.rs Outdated Show resolved Hide resolved

my-vegetable-has-exploded force-pushed the int8vector branch from a06df80 to fa23dab Compare February 22, 2024 14:23

VoVAllen reviewed Feb 23, 2024

View reviewed changes

my-vegetable-has-exploded added 5 commits February 24, 2024 22:24

impl veci8 operator.

81b1462

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

implement G for I8.

3dcc5ce

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

rm useless code in i8 scalar.

cbb72d0

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

implement operators & binary & subscript.

b4b51b9

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

add e2e tests.

bc7cece

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

my-vegetable-has-exploded force-pushed the int8vector branch from 4d643c5 to bc7cece Compare February 24, 2024 14:25

fix tests.

4d67d49

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

my-vegetable-has-exploded marked this pull request as ready for review February 24, 2024 15:55

Merge remote-tracking branch 'origin/main' into int8vector

7842b01

my-vegetable-has-exploded added 2 commits February 25, 2024 21:35

fix merge.

040f17b

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

fix typos.

760f48c

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

usamoi reviewed Feb 26, 2024

View reviewed changes

my-vegetable-has-exploded added 3 commits February 28, 2024 15:28

fix vnni & fix comments.

b91e01d

fix dot_vnni add more tests for similarity. Add sum and l2_norm for Veci8Header. fix other comments. Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

Merge remote-tracking branch 'origin/main' into int8vector

67c85a3

fix merge.

b6d6f66

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

my-vegetable-has-exploded force-pushed the int8vector branch from acae3cb to b6d6f66 Compare February 28, 2024 15:30

usamoi reviewed Feb 29, 2024

View reviewed changes

src/sql/finalize.sql Outdated Show resolved Hide resolved

usamoi reviewed Feb 29, 2024

View reviewed changes

src/sql/finalize.sql Outdated Show resolved Hide resolved

src/datatype/text_veci8.rs Outdated Show resolved Hide resolved

crates/base/src/global/veci8.rs Show resolved Hide resolved

my-vegetable-has-exploded added 2 commits February 29, 2024 12:59

Merge remote-tracking branch 'origin/main' into int8vector

dd09937

fix merge.

7f7ffb3

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

fix vnni_dot saturating & fix sql position.

c666b8d

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

usamoi previously approved these changes Mar 1, 2024

View reviewed changes

src/sql/finalize.sql Outdated Show resolved Hide resolved

VoVAllen reviewed Mar 1, 2024

View reviewed changes

src/sql/finalize.sql Outdated Show resolved Hide resolved

Change EXTERNAL & fmt tab.

68b4aca

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>

my-vegetable-has-exploded dismissed usamoi’s stale review via 68b4aca March 3, 2024 02:43

usamoi added 2 commits March 4, 2024 14:41

Merge branch 'main' into int8vector

5b61667

resolve conflicts

db09e7d

Signed-off-by: usamoi <usamoi@outlook.com>

usamoi added this pull request to the merge queue Mar 4, 2024

Merged via the queue into tensorchord:main with commit 3a56a8c Mar 4, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support veci8 #326

feat: support veci8 #326

my-vegetable-has-exploded commented Jan 31, 2024

VoVAllen left a comment

VoVAllen commented Feb 25, 2024

usamoi commented Feb 28, 2024 via email

my-vegetable-has-exploded commented Feb 28, 2024

usamoi commented Feb 29, 2024 •

edited

Loading

VoVAllen commented Feb 29, 2024

my-vegetable-has-exploded commented Feb 29, 2024

usamoi commented Mar 1, 2024

my-vegetable-has-exploded commented Mar 1, 2024

my-vegetable-has-exploded commented Mar 4, 2024

feat: support veci8 #326

feat: support veci8 #326

Conversation

my-vegetable-has-exploded commented Jan 31, 2024

VoVAllen left a comment

Choose a reason for hiding this comment

VoVAllen commented Feb 25, 2024

usamoi commented Feb 28, 2024 via email

my-vegetable-has-exploded commented Feb 28, 2024

usamoi commented Feb 29, 2024 • edited Loading

VoVAllen commented Feb 29, 2024

my-vegetable-has-exploded commented Feb 29, 2024

usamoi commented Mar 1, 2024

my-vegetable-has-exploded commented Mar 1, 2024

my-vegetable-has-exploded commented Mar 4, 2024

usamoi commented Feb 29, 2024 •

edited

Loading