Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically changes the password when the field kept blank #78

Closed
Manjit2003 opened this issue Mar 1, 2021 · 2 comments · Fixed by #79
Closed

Automatically changes the password when the field kept blank #78

Manjit2003 opened this issue Mar 1, 2021 · 2 comments · Fixed by #79
Assignees
Labels
bug Something isn't working

Comments

@Manjit2003
Copy link

Manjit2003 commented Mar 1, 2021

Bug report

Describe the bug

Whenever I edit the user for example I have extened the user using

      .setup(({ user }) => {
        user.fields([
          text("Avatar").nullable(),
          select("Role").options(["Student", "Reviewer"]).nullable(),
        ]);
      })

then whenever I try to edit the avatar of user from the cms, i keep the password field blank... But whenever the user trys to log in it shows invalid credentials

Steps to reproduce the behavior

  1. Extend the user table using
      .setup(({ user }) => {
        user.fields([
          text("Avatar").nullable(),
          select("Role").options(["Student", "Reviewer"]).nullable(),
        ]);
      })
  1. Create any user
  2. Then try to login using the credentials, it will login successfully
  3. Then edit the avatar of the user, the password gets changed automatically

Expected behavior

Only the avatar should change, not the password

@bahdcoder bahdcoder self-assigned this Mar 2, 2021
@bahdcoder
Copy link
Member

Hey thanks a lot for reporting this. I'll ship a fix for this bug very soon!

Awesome to see you using a lot of these features already ! Thank you very much !

@bahdcoder bahdcoder added the bug Something isn't working label Mar 2, 2021
bahdcoder pushed a commit that referenced this issue Mar 2, 2021
when a resource is being updated on a form on the cms, if the field is untouched, the cms updates
the database value nonetheless. this fix makes sure if a field is untouched, its database value is
also untouched

fix #78
bahdcoder pushed a commit that referenced this issue Mar 2, 2021
when a resource is being updated on a form on the cms, if the field is untouched, the cms updates
the database value nonetheless. this fix makes sure if a field is untouched, its database value is
also untouched

fix #78
bahdcoder pushed a commit that referenced this issue Mar 2, 2021
when a resource is being updated on a form on the cms, if the field is untouched, the cms updates
the database value nonetheless. this fix makes sure if a field is untouched, its database value is
also untouched

fix #78
bahdcoder added a commit that referenced this issue Mar 2, 2021
when a resource is being updated on a form on the cms, if the field is untouched, the cms updates
the database value nonetheless. this fix makes sure if a field is untouched, its database value is
also untouched

fix #78
@bahdcoder
Copy link
Member

hello @Manjit2003 I just published a patch that fixes this bug. Can you please update to the latest version (v0.7.17) and give it another try ? Should work fine now.

Let me know if you need any help !

Thank you very much for trying it out and providing feedback !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants