blockchain: proto transition #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding in buf as a proto tool to help with linting and breakage checking ref #4288 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* tests: bind test servers to 127.0.0.1 (#4322) * rpc: PR#4320 follow up (#4323) * rpc: update urls to rpc website * rpc: check blockMeta is not nil in Commit Refs #4319 * change protocgen file to use thirdparty * exclude third_party * buf.yaml change Co-authored-by: Erik Grinaker <erik.grinaker@cognite.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
* proto: move mempool to proto - changes according to moving the mempool reactor to proto Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
melekes
reviewed
Apr 8, 2020
melekes
reviewed
Apr 8, 2020
|
TODO
|
|
@milosevic FYI I'm writing tests for utils in #4663 |
|
This pull request introduces 1 alert when merging 533b5b8 into 8b454b5 - view on LGTM.com new alerts:
|
tac0turtle
added a commit
that referenced
this pull request
Jun 5, 2020
Transition the blockchain reactor(s) to protobuf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transition the blockchain reactor(s) to protobuf
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer