-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validation swap msg and offerCoinFee ceiling #436
fix: validation swap msg and offerCoinFee ceiling #436
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #436 +/- ##
===========================================
+ Coverage 83.36% 85.13% +1.76%
===========================================
Files 20 20
Lines 2302 2596 +294
===========================================
+ Hits 1919 2210 +291
- Misses 218 223 +5
+ Partials 165 163 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
closes: #435
OfferCoinFee
, the decimal points are rounded up.MsgSwapWithinBatch
validation andOfferCoinFee
calculationBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes