Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitempty on JSON decoder #262

Merged
merged 2 commits into from
May 2, 2019
Merged

Omitempty on JSON decoder #262

merged 2 commits into from
May 2, 2019

Conversation

mossid
Copy link
Contributor

@mossid mossid commented May 1, 2019

Closes: #261

@mossid mossid changed the title Update json-decode.go Omitempty on JSON decoder May 1, 2019
@alexanderbez
Copy link

It would be ideal to get this into the SDK before we release v0.35.0. It'll make parameter change proposals much easier to write (ie. you won't have to include the entire struct -- only the fields you want to change).

/cc @liamsi

@liamsi
Copy link
Contributor

liamsi commented May 1, 2019

ref: #261

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi changed the base branch from master to develop May 2, 2019 07:55
@liamsi
Copy link
Contributor

liamsi commented May 2, 2019

Changed the base branch to develop. Will cut a release containing this change later today.

@liamsi liamsi merged commit fc5dc13 into develop May 2, 2019
@alexanderbez
Copy link

Great, thanks @liamsi!

@liamsi liamsi deleted the joon/261-json-decode-omitempty branch May 15, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants