Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terrascan should exit with non zero exit code when scan error are present #994

Merged
merged 2 commits into from
Aug 19, 2021
Merged

terrascan should exit with non zero exit code when scan error are present #994

merged 2 commits into from
Aug 19, 2021

Conversation

patilpankaj212
Copy link
Contributor

  1. exit with 5 when scan errors are present with violations
  2. exit with 4 when scan errors are present without violations

@patilpankaj212 patilpankaj212 linked an issue Aug 16, 2021 that may be closed by this pull request
Terrascan does not exit with error code in pipeline or CLI #950
Closed
@codecov
Copy link

codecov bot commented Aug 16, 2021 •
edited
Loading

Codecov Report

Merging #994 (085038b) into master (687863e) will decrease coverage by 0.00%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   78.58%   78.58%   -0.01%     
==========================================
  Files         224      224              
  Lines        5650     5659       +9     
==========================================
+ Hits         4440     4447       +7     
- Misses        930      932       +2     
  Partials      280      280
Impacted Files Coverage Δ
pkg/cli/run.go 87.65% <63.63%> (-1.24%) ⬇️

cesar-rodriguez
cesar-rodriguez suggested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@cesar-rodriguez cesar-rodriguez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the Readme and docs explaining the new error codes?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cesar-rodriguez cesar-rodriguez merged commit 5c6a2c1 into tenable:master Aug 19, 2021
@HorizonNet HorizonNet mentioned this pull request Oct 25, 2021
Open
@patilpankaj212 patilpankaj212 deleted the modify_exit_codes branch May 5, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesar-rodriguez cesar-rodriguez cesar-rodriguez approved these changes

@Rchanger Rchanger Awaiting requested review from Rchanger

@nasir-rabbani nasir-rabbani Awaiting requested review from nasir-rabbani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terrascan does not exit with error code in pipeline or CLI
2 participants
@patilpankaj212 @cesar-rodriguez